On 27/07/2015 13:26, Michael S. Tsirkin wrote:
>>> > > +        if (s->conf.scsi) {
>>> > > +            error_setg(errp, "Virtio 1.0 does not support scsi 
>>> > > passthrough!");
>> > 
>> > Unclear error message, as one would expect SCSI passthrough not to work
>> > anyway for e.g. a disk backed by a file.
> Right - so I suggested:
>       Virtio modern does not support scsi passthrough - please set 
> disable-modern=on or switch to virtio-scsi.
> With that change - ACK?

scsi=on by default, so everyone is getting the message until they
disable virtio 1.0.  Suggesting a switch to virtio-scsi doesn't make sense.

Your proposal makes sense once scsi=off by default.  Until then, what
about "please set scsi=off for virtio-blk devices in order to use virtio
1.0"?

Paolo

Reply via email to