On 28/07/2015 17:08, Igor Mammedov wrote: >> > hw/mem/pc-dimm.c | 7 +++++++ >> > hw/virtio/vhost-backend.c | 23 ++++++++++++++++++++++- >> > hw/virtio/vhost-user.c | 8 +++++++- >> > hw/virtio/vhost.c | 21 +++++++++++++++++++++ >> > include/hw/virtio/vhost-backend.h | 2 ++ >> > include/hw/virtio/vhost.h | 1 + >> > stubs/Makefile.objs | 1 + >> > stubs/vhost.c | 6 ++++++ >> > 8 files changed, 67 insertions(+), 2 deletions(-) >> > create mode 100644 stubs/vhost.c >> > > ping, > > patches are not invasive and fix QEMU crash during memory hotplug > when running on kernels that have lower vhost memory slots limit. > Pls consider applying them for 2.4.
I like the approach. For 2.5 we could consider using a NotifierWithReturn: it can be easily extended to cover KVM as well and removes the need for the stub. Paolo
