On Fri 31 Jul 2015 11:19:13 AM CEST, Wen Congyang wrote:
> Signed-off-by: Wen Congyang <we...@cn.fujitsu.com>
> Signed-off-by: zhanghailiang <zhang.zhanghaili...@huawei.com>
> Signed-off-by: Gonglei <arei.gong...@huawei.com>
> Cc: Alberto Garcia <be...@igalia.com>
> ---
> block/quorum.c | 74
> ++++++++++++++++++++++++++++++++++++++++++++++++++++++++--
> 1 file changed, 72 insertions(+), 2 deletions(-)
The description is confusing, I suggest something like
"quorum: implement bdrv_add_child() and bdrv_del_child()"
> + if (s->num_children <= s->threshold) {
> + error_setg(errp, "Cannot remove any more child");
> + return;
> + }
See also my comments about this error message in one of my earlier
e-mails.
Otherwise it looks good to me, I saw that you added the bdrv_unref()
line, thanks!
Berto
