This implements some extras code cleanups in the PC code: * Use PC_COMPAT_* instead of a special compat function for X86 CPUID compatibility * Use error_abort where appropriate * Rename PCMachineState variables consistently * Move some local variables from pc_init1() and pc_q35_init() to PCMachineState, so initialization functions can get that info from a PCMachineState* argument directly * Move some compat global variables to PCMachineClass, and move compatibility code from pc_compat_*() functions to the corresponding *_machine_options() function
Eduardo Habkost (18): pc: Use PC_COMPAT_* for CPUID feature compatibility target-i386: Remove x86_cpu_compat_set_features() pc: Use error_abort when registering properties pc: Rename pc_machine variables to pcms pc: Move PCMachineClass, PCMachineState to qemu/typedefs.h pc: Eliminate pc_common_machine_options() pc: Eliminate pc_default_machine_options() pc: Use PCMachineState for pc_cmos_init() argument pc: Use PCMachineState for pc_memory_init() argument pc: Move {above,below}_4g_mem_size variables to PCMachineState pc: Use PCMachineState as pc_guest_info_init() argument pc: Remove redundant arguments from *load_linux() pc: Remove redundant arguments from pc_cmos_init() pc: Remove redundant arguments from pc_memory_init() pc: Remove redundant arguments from xen_hvm_init() pc: Move compat boolean globals to PCMachineClass pc: Move legacy_acpi_table_size global to PCMachineClass pc: Move acpi_data_size global to PCMachineClass hw/i386/pc.c | 121 +++++++++++++++-------------- hw/i386/pc_piix.c | 201 +++++++++++++++++++----------------------------- hw/i386/pc_q35.c | 123 +++++++++++------------------ include/hw/i386/pc.h | 167 ++++++++++++++++++++++++++++++++-------- include/hw/xen/xen.h | 4 +- include/qemu/typedefs.h | 2 + target-i386/cpu.c | 26 ------- target-i386/cpu.h | 3 - xen-hvm.c | 25 +++--- 9 files changed, 339 insertions(+), 333 deletions(-) -- 2.1.0