On 11.05.2010, at 00:13, Sebastian Herbszt wrote: > Alexander Graf wrote: >> Hi Chong, >> >> On 10.05.2010, at 13:55, QiaoChong wrote: >> >> > When ahci init ,driver will send ATA_SRST command,ahci device report >> > device type through port's sig register. >> > Ahci disk lookup change from IF_SD to IF_SCSI now,because IF_SD does not >> > support cdrom media. >> > I just copy ide_atapi_cmd from hw/ide/core.c into hw/ahci.c,change a >> > little,then the cdrom can be identified,and > read by os. >> > If qemu can change dma_buf_prepare,dma_buf_rw,dma_buf_commit to a function >> > pointer in BMDMAState,then I can rewrite > three functions to support >> > ahci's prtd,because it is different from ide's. >> > >> > test a sata disk like this: >> > ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive >> > if=scsi,file=/tmp/disk >> > test a sata cd like this: >> > ./i386-softmmu/qemu -cdrom KNOPPIX_V6.0.1CD-2009-02-08-EN.iso -drive > >> > if=scsi,media=cdrom,file=KNOPPIX_V6.0.1CD-2009-02-08-EN.iso >> >> Thanks for improving the patch, but I have some nitpicks considering on how >> to process here. >> >> For starters, this patch is incremental to the previous one. Since the >> previous patch did not get applied to qemu, it doesn't make sense to send an >> incremental patch. Please send the full patchset but bump up > the version >> in that case. You will find many examples for that on the mailing list. In >> most cases it also makes sense to rethink the splitting between patches. > > The problem of incremental patches will be a non issue as soon as the git > tree is available.
I set up a mailing list and a git tree for development. The mailing list is here: https://lists.sourceforge.net/lists/listinfo/qemu-ahci-devel The git tree is here (pure mirror of qemu at this moment): git://repo.or.cz/qemu/ahci.git Could you guys please send me all the patches you have so far so I can put them into an ahci branch? Please also register with repo.or.cz so I can give you commit rights. If things become too messy, I'll try to put me or Roland as gatekeeper for patches into the repo. Alex