On Fri, Aug 14, 2015 at 10:52:00PM +0800, Xiao Guangrong wrote: > diff --git a/hw/mem/nvdimm/pc-nvdimm.c b/hw/mem/nvdimm/pc-nvdimm.c > index a53d235..7a270a8 100644 > --- a/hw/mem/nvdimm/pc-nvdimm.c > +++ b/hw/mem/nvdimm/pc-nvdimm.c > @@ -24,6 +24,19 @@ > > #include "hw/mem/pc-nvdimm.h" > > +#define PAGE_SIZE (1UL << 12)
This macro name is likely to collide with system headers or other code. Could you use the existing TARGET_PAGE_SIZE constant instead?
