On 13 August 2015 at 18:09, Wei Huang <w...@redhat.com> wrote: > This patch adds support for SMBIOS 3.0 entry point. When caller invokes > smbios_set_defaults(), it can specify entry point as 2.1 or 3.0. Then > smbios_get_tables() will return the entry point table in right format.
> -/* SMBIOS entry point (anchor). > - * BIOS must place this at a 16-bit-aligned address between 0xf0000 and > 0xfffff. > +/* SMBIOS entry point > + * BIOS must place this at a 16-bit-aligned address between 0xf0000 > + * and 0xfffff. > */ > -struct smbios_entry_point { > +struct smbios_21_entry_point { > uint8_t anchor_string[4]; > uint8_t checksum; > uint8_t length; > @@ -58,6 +52,25 @@ struct smbios_entry_point { > uint8_t smbios_bcd_revision; > } QEMU_PACKED; This breaks 'make check' for x86, because tests/bios-tables-test.c still uses 'struct smbios_entry_point' and no longer compiles if this patch is applied. I'm removing these two patches from my target-arm queue. thanks -- PMM