Hi Stefan,
On 08/28/2015 07:58 PM, Stefan Hajnoczi wrote:
+ goto do_unmap;
+ }
+
+ nvdimm->device_index = new_device_index();
+ sprintf(name, "NVDIMM-%d", nvdimm->device_index);
+ memory_region_init_ram_ptr(&nvdimm->mr, OBJECT(dev), name, nvdimm_size,
+ buf);
How is the autogenerated name used?
Why not just use "pc-nvdimm.memory"?
Ah. Just for debug proposal :) and i am not sure if a name used for multiple
MRs (MemoryRegion) is a good idea.
Other devices use a constant name too (git grep
memory_region_init_ram_ptr) so it seems to be okay. The unique thing is
the OBJECT(dev) which differs for each NVDIMM instance.
When I was digging into live migration code, i noticed that the same MR name may
cause the name "idstr", please refer to qemu_ram_set_idstr().
Since nvdimm devices do not have parent-bus, it will trigger the abort() in that
function.
