Avi Kivity <a...@redhat.com> writes: > On 05/14/2010 11:50 AM, Markus Armbruster wrote: >> >>>> + >>>> +{ "execute": "migrate_set_speed", "arguments": { "value": 1024 } } >>>> >>>> >>> Oh, we do have more. >>> >>> Please document the units for this value (bits per second)? >>> >> bytes per second? >> > > Bandwidth is typically measured in bits per second.
The question is what unit the code actually uses. What it should use is separate, if valid question. >>>> +- "bus": identical to the parent's bus number (json-int) >>>> +- "slot": slot number (json-int) >>>> +- "function": function number (json-int) >>>> >>>> >>> Would have been nicer as a nested object (list of buses, each >>> containing a list of slots, each containing a list of functions). >>> >> We have a list of buses, each containing a list of device functions. >> Not sure the additional level of nesting you propose buys us anything. >> > > A slot is the hotpluggable entity. Open your computer and you can > actually see them. QEMU doesn't really know that. > btw would be good to list empty slots as well. Why? > What about PCI domains? Good point. Better to provide for them neatly now, instead of kludging them in later.