On 09/07/2015 04:16 AM, Markus Armbruster wrote: > qapi/introspect.json defines the introspection schema. It's designed > for QMP introspection, but should do for similar uses, such as QGA. > > The introspection schema does not reflect all the rules and > restrictions that apply to QAPI schemata. A valid QAPI schema has an > introspection value conforming to the introspection schema, but the > converse is not true. > > Introspection lowers away a number of schema details, and makes > implicit things explicit: >
> +## > +# @SchemaInfoObjectMember > +# > +# An object member. > +# > +# @name: the member's name, as defined in the QAPI schema. > +# > +# @type: the name of the member's type. > +# > +# @default: #optional default when used as command parameter. > +# If absent, the parameter is mandatory. > +# If present, the value must be null. The parameter is > +# optional, and behavior when it's missing is not specified > +# here. > +# Future extension: if present and non-null, the parameter > +# is optional, and defaults to this value. > +# > +## > +# @SchemaInfoObjectVariant > +# > +# The variant members for a value of the type tag. > +# > +# @case: a value of the type tag. > +# > +# @type: the name of the object type that provides the variant members > +# when the type tag has value @case. You aren't consistent on whether secondary lines describing the same @variable are indented or flush left. I don't care enough to hold up review, but just pointing it out in case you want to reflow some text. I've finished re-reading 31 and 32, and double-checking that the combined text of all three patches together makes sense as a whole. Looks like we're ready for this series to come out of RFC soon :) And I'll start rebasing and posting my followup patches that have already been on list... -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature