On 05/17/10 14:04, Julian Pidancet wrote:
On 05/17/2010 11:53 AM, Gerd Hoffmann wrote:
+directfb="no"

Should be ="" (aka autodetect).




+if test "$directfb" = "yes" ; then
+  directfb_libs=`directfb-config --libs`
+  directfb_cflags=`directfb-config --cflags`
+  libs_softmmu="$directfb_libs $libs_softmmu"
+fi

use pkgconfig here.  directfb-config most likely is just a pkgconfig
wrapper anyway.


Unfortunately, directfb-config is not a pkgconfig wrapper, it is a standalone 
shell script.
Thus, I don't know if there is an easier way of "autodetecting" directfb than 
probing the directfb-config script.


'pkg-config directfb'
        exit code 0 => success
        exit code 1 => failure

pkg-config --cflags directfb
        finds cflags

Check 'pkg-config --help' && man page for more info.

Oh, and btw: the patch doesn't build when applied to latest master bits.

HTH,
  Gerd

Reply via email to