On Mon, Sep 14, 2015 at 07:57:44PM +0200, Markus Armbruster wrote: > Generate just 'FOO' instead of 'struct FOO' when possible. > > Drop helper functions that are now unused. > > Make pep8 and pylint reasonably happy. > > Rename generate_FOO() functions to gen_FOO() for consistency. > > Use more consistent and sensible variable names. > > Consistently use c_ for mapping keys when their value is a C > identifier or type. > > Simplify gen_enum() and gen_visit_union() > > Consistently use single quotes for C text string literals.
I would have preferred to see one type of change per patch to make review easier, but this has been through enough iterations now that no point changing again. > > Signed-off-by: Markus Armbruster <arm...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > --- > docs/qapi-code-gen.txt | 2 +- > scripts/qapi-commands.py | 140 > ++++++++++++++++++++++++++--------------------- > scripts/qapi-event.py | 122 ++++++++++++++++++++--------------------- > scripts/qapi-types.py | 79 ++++++++++++++------------ > scripts/qapi-visit.py | 127 ++++++++++++++++++++++-------------------- > scripts/qapi.py | 131 +++++++++----------------------------------- > 6 files changed, 274 insertions(+), 327 deletions(-) Reviewed-by: Daniel P. Berrange <berra...@redhat.com> Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
