On Tue, May 18, 2010 at 11:18 AM, Alexander Graf <ag...@suse.de> wrote: > > On 18.05.2010, at 09:31, Corentin Chary wrote: > > This is missing a patch description. When people later on either cherry-pick > your commits or simply git show them, it's almost impossible to know what's > going on. > So please always put in a patch description. > > > Alex >
In this case, the description is all in the subject and the patch is pretty obvious. Should I really add something like "Create a new set_encoding() function to remove duplicate code in set_encodings()." ? -- Corentin Chary http://xf.iksaif.net
