On 7 September 2015 at 10:53, Paolo Bonzini <pbonz...@redhat.com> wrote: > Mostly change severity levels, but some tests can also be adjusted to refer > to QEMU APIs or data structures. > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com>
> @@ -1956,9 +1941,14 @@ sub process { > ERROR("open brace '{' following $1 go on the same > line\n" . $hereprev); > } > > +# ... however, open braces on typedef lines should be avoided. > + if ($line =~ > /^.\s*typedef\s+(enum|union|struct)(?:\s+$Ident\b)?.*[^;]$/) { > + ERROR("typedefs should be separate from struct > declaration\n" . $herecurr); > + } > + > # missing space after union, struct or enum definition Can we revert this one, please? Checkpatch now warns about constructs like typedef struct MyDevice { DeviceState parent; int reg0, reg1, reg2; } MyDevice; which I think are common practice throughout QEMU (recommended as part of the examples in include/qom/object.h and in http://wiki.qemu.org/QOMConventions, for instance). $ git grep 'typedef struct.*{' |wc -l 1884 thanks -- PMM