Wen Congyang <we...@cn.fujitsu.com> writes: > On 09/18/2015 04:11 AM, Eric Blake wrote: >> On 09/17/2015 08:34 AM, Eric Blake wrote: >> >>>> >>>> I apply Markus's v8 patch and this series, make check will fail: >>>> TEST: tests/virtio-net-test... (pid=23648) >>>> /x86_64/virtio/net/pci/basic: qemu-system-x86_64: -netdev >>>> socket,fd=6,id=hs0: Invalid parameter 'fd' >>> >>> Oh dear. I guess I was focused on 'make check-qapi-schema', and forgot >>> to test the rest of the suite. The bug is most likely in my patches, >>> and will be fixed by the time I post v5, now that you've pointed it out >>> to me. >> >> Fix is simple: add this patch to your build: >> >> https://lists.gnu.org/archive/html/qemu-devel/2015-09/msg01650.html >> >> I've rebased my git repo accordingly for now, and will post v5 later on >> (I'm still working on other improvements, and may reshuffle patches >> before actually getting to v5). >> >> git fetch git://repo.or.cz/qemu/ericb.git qapi >> http://repo.or.cz/qemu/ericb.git/shortlog/refs/heads/qapi >> > > OK, I will try it. What is difference between start_struct() and > start_implicit_struct()?
I hope to be able to answer this question next week, after taking a dive in the (almost entirely undocumented) visitors code.
