Am 18.09.2015 um 16:24 schrieb Markus Armbruster: > Andreas Färber <afaer...@suse.de> writes: >> Am 18.09.2015 um 14:00 schrieb Markus Armbruster: >>> Add it to check-qtest-generic-y instead of check-qtest-$(target)-y for >>> every target. >>> >>> Signed-off-by: Markus Armbruster <arm...@redhat.com> >>> --- >>> tests/Makefile | 5 +---- >>> 1 file changed, 1 insertion(+), 4 deletions(-) >>> >>> diff --git a/tests/Makefile b/tests/Makefile >>> index 4559045..28c5f93 100644 >>> --- a/tests/Makefile >>> +++ b/tests/Makefile >>> @@ -219,10 +219,7 @@ gcov-files-ppc64-y += ppc64-softmmu/hw/ppc/spapr_pci.c >>> check-qtest-microblazeel-y = $(check-qtest-microblaze-y) >>> check-qtest-xtensaeb-y = $(check-qtest-xtensa-y) >>> >>> -# qom-test works for all sysemu architectures: >>> -$(foreach target,$(SYSEMU_TARGET_LIST), \ >>> - $(if $(findstring tests/qom-test$(EXESUF), >>> $(check-qtest-$(target)-y)),, \ >>> - $(eval check-qtest-$(target)-y += tests/qom-test$(EXESUF)))) >>> +check-qtest-generic-y += tests/qom-test$(EXESUF) >> >> Does this -generic- have the same filtering code to avoid running the >> tests twice for x86_64, aarch64, ppc64, etc.? Please don't regress. > > I'm dense today. Can you explain the filtering code to me?
For practical purpose,s x86_64 adds all tests from i386, that included qom-test then. If we now add it for x86_64 too, it got executed twice, which the above $(if ...) fixes by not adding it for x86_64 if it's already in. Just checking whether -generic- has equivalent filtering or other code somewhere else? BR, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton; HRB 21284 (AG Nürnberg)
