On Mon, Sep 21, 2015 at 11:11:47AM +0530, Bharata B Rao wrote: > On Sat, Sep 19, 2015 at 1:08 AM, Eduardo Habkost <ehabk...@redhat.com> wrote: > > QOM instance_init functions are not supposed to have any side-effects, > > as new objects may be created at any moment for querying property > > information (see qmp_device_list_properties()). > > > > Calling cpu_exec_init() also affects QEMU's ability to handle errors > > during CPU creation, as some actions done by cpu_exec_init() can't be > > reverted. > > > > Move cpu_exec_init() call to realize so a simple object_new() won't > > trigger it, and so that it is called after some basic validation of CPU > > parameters. > > Since you are moving cpu_exec_init() to realize, does it make sense to > define unrealize and call cpu_exec_exit() from it ?
It does make sense. But it needs to be done more carefully because currently cpu_exec_exit() is likely to make QEMU crash, and calling it from unrealize would make the crash triggerable using a QMP qom-set command. -- Eduardo
