On Tue, Sep 22, 2015 at 02:04:35PM +0200, Paolo Bonzini wrote: > > > On 18/09/2015 15:19, Daniel P. Berrange wrote: > > The Buffer code in the VNC server is useful for the IO channel > > code, so pull it out into a shared module, QIOBuffer. > > Do all traces disappear from VNC once you're done? If not, can you > instead move it to util/?
It is still used in VNC code for decoding of various framebuffer encodings. Only the websock usage gets eliminated. I'm happy to move it to util/ directory. Any preference on a name for the APIs. I used QIOBuffer since i placed it under io/ directory. Could keep that name when moved to util/, or give it a different one. > > Signed-off-by: Daniel P. Berrange <berra...@redhat.com> > > --- > > include/io/buffer.h | 118 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++ > > io/Makefile.objs | 3 +- > > io/buffer.c | 65 +++++++++++++++++++++++++++++ > > ui/vnc-auth-sasl.c | 4 +- > > ui/vnc-enc-tight.c | 38 ++++++++--------- > > ui/vnc-enc-zlib.c | 6 +-- > > ui/vnc-enc-zrle.c | 18 ++++---- > > ui/vnc-jobs.c | 15 +++---- > > ui/vnc-ws.c | 36 ++++++++-------- > > ui/vnc-ws.h | 6 +-- > > ui/vnc.c | 67 ++++++----------------------- > > ui/vnc.h | 50 ++++++++-------------- > > 12 files changed, 277 insertions(+), 149 deletions(-) > > create mode 100644 include/io/buffer.h > > create mode 100644 io/buffer.c Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|