On 22 September 2015 at 05:18, Gerd Hoffmann <kra...@redhat.com> wrote: > On Di, 2015-09-15 at 12:25 +0200, Gerd Hoffmann wrote: >> On Do, 2015-09-03 at 14:32 +0100, Peter Maydell wrote: >> > On 3 September 2015 at 14:02, Gerd Hoffmann <kra...@redhat.com> wrote: >> > > Hi, >> > > >> > > Here comes the ipxe update pull. Thanks to Stefan all bits are upstream >> > > now. Also upstream has a named configuration for qemu. That simplifies >> > > the whole process, I could drop some patches and so there are only 4 of >> > > them left, two of them being the actual ipxe update (one submodule, one >> > > binaries). >> > > >> > > Note that this is NOT current git master. Michael Brown added support >> > > for EFI_PXE_BASE_CODE_PROTOCOL recently, and I tried to pick the last >> > > commit before that work started to have a stable and known-good base. >> > > >> > > I'll have a look a the new code shortly though, so stay tuned for more >> > > ipxe updates. >> > >> > These patches appear to be not merely trivial "update submodule", >> > but some other changes too. I'd prefer them to appear on the list >> > as patches first for review, rather than making their first >> > appearance in a pull request. >> >> Patches have been on the list now for a week, without comments. >> Pull now? > > Ping?
OK. I had a look through them and they seemed OK, though I wasn't solid enough on the area to actually call that a review. PS: if you want my attention on a pull request your email must contain the magic words for my email filter to find it, which is why I didn't see your previous request from a week ago. thanks -- PMM