Hi, On 09/17/2015 01:38 PM, Shlomo Pongratz wrote: > From: Pavel Fedin <p.fe...@samsung.com> > > I would like to offer this, slightly improved implementation. The key thing > is a new > kernel_irqchip_type member in Machine class. Currently it it used only by > virt machine for > its internal purposes, however in future it is to be passed to KVM in > kvm_irqchip_create(). The variable is defined as int in order to be > architecture agnostic, > for potential future users. > > Signed-off-by: Pavel Fedin <p.fe...@samsung.com> > --- > hw/arm/virt.c | 72 > +++++++++++++++++++++++++++++++++++++++++++++------ > include/hw/arm/fdt.h | 2 ++ > include/hw/arm/virt.h | 1 + > target-arm/machine.c | 7 ++++- > 4 files changed, 73 insertions(+), 9 deletions(-) > > diff --git a/hw/arm/virt.c b/hw/arm/virt.c > index 4d15309..4c2ae7f 100644 > --- a/hw/arm/virt.c > +++ b/hw/arm/virt.c
> @@ -445,6 +462,14 @@ static void create_gic(VirtBoardInfo *vbi, qemu_irq > *pic, int type, bool secure) > sysbus_mmio_map(gicbusdev, 1, vbi->memmap[VIRT_GIC_CPU].base); > } > > + if (type == 3) { > + /* Connect GIC to CPU */ > + for (i = 0; i < smp_cpus; i++) { > + CPUState *cpu = qemu_get_cpu(i); > + aatch64_registers_with_opaque_set(OBJECT(cpu), (void *)gicdev); Typo--should be "aarch64". With that, feel free to add the following if it's any use: Tested-by: Christopher Covington <c...@codeaurora.org> -- Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project