On 09/25/2015 08:03 AM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > Clean-up qmp-commands.hx from examples. > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > --- > qapi-schema.json | 1128 +++++++++++++++- > qapi/block-core.json | 365 +++++ > qapi/block.json | 32 + > qapi/common.json | 32 + > qapi/rocker.json | 43 + > qapi/trace.json | 12 + > qmp-commands.hx | 3617 > +------------------------------------------------- > 7 files changed, 1625 insertions(+), 3604 deletions(-)
Mammoth patch. I don't know if it would make sense to break it into smaller pieces (say 10 or so related commands per patch) - more emails, but each email is more reviewable, and the review can be divided among the various maintainers that implement those various commands. Or even if there were an easy way to automate the diff to prove that every example was exactly moved, regardless of whether the example is correct. I'm not necessarily opposed to keeping it as one big patch, just that it is a big commitment to review. And I do like where we end up, it's just that I'm worried about making sure we don't regress along the way (particularly if other QMP command examples are introduced along the way before this gets merged - we already had a recent example of a regression in -help output for PCI devices due to text being added to one file in parallel with another patch that moved the text between files). Also, I'd love to see docs/qapi-code-gen.txt updated to list Example: as a proper part of a sample qapi listing. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
