> On Tue, Sep 22, 2015 at 04:06:54 -0400, Prasanna Kalever wrote: > > > > > On 09/21/2015 05:24 AM, Prasanna Kumar Kalever wrote: > > > > This patch adds a way to specify multiple backup volfile servers to the > > > > gluster > > > > block backend of QEMU with tcp|rdma transport types and their port > > > > numbers. > > > > > > > > ter > ... > > > > > > > +## > > > > +{ 'struct': 'BlockdevOptionsGluster', > > > > + 'data': { 'volname': 'str', > > > > + 'image-path': 'str', > > > > + 'backup-volfile-servers': [ 'GlusterTuplePattern' ] } } > > > > > > Shouldn't this be simply 'volfile-servers', as you are including the > > > primary server in addition to the backup servers? > > > > > > > Again I want to maintain naming as mount.glusterfs do for fuse. > > Well, I have to agree with Eric here. I think the option name doesn't > need to be kept in sync with the gluster implementation since they don't > share anything with qemu and since the array contains also the primary > server to be queried the word backup doesn't make snese there.
Yes Peter, I have to agree with you and Eric. I will rectify this changes in next patch-set, just waiting for 'gfapi' patch to get merged. Thank you, Best Regards, Prasanna Kumar Kalever. > > Peter >