On Mon, Sep 28, 2015 at 12:34 AM, Peter Crosthwaite <crosthwaitepe...@gmail.com> wrote: > On Sun, Sep 27, 2015 at 1:58 PM, Max Filippov <jcmvb...@gmail.com> wrote: >> + qdev_prop_set_uint16(dev, "id0", 0x00); >> + qdev_prop_set_uint16(dev, "id1", 0x00); >> + qdev_prop_set_uint16(dev, "id2", 0x00); >> + qdev_prop_set_uint16(dev, "id3", 0x00); > > You can drop the ID setters to 0x00. That's the default. Otherwise: > > Reviewed-by: Peter Crosthwaite <crosthwaite.pe...@gmail.com>
Ok. > Something out of scope and possible follow-up: As these are real > boards, ideally we have the ID for the actual parts populated. For > ML605, the petalogix_ml605_mmu machine model does have this as > non-zero. So far there were no need in this level of detail. -- Thanks. -- Max
