On 26/09/2015 18:15, Eric Blake wrote: > On 09/25/2015 02:37 AM, Shraddha Barke wrote: >> Compress lines and remove the variable. >> > >> +++ b/target-ppc/kvm.c >> @@ -1782,8 +1782,7 @@ uint32_t kvmppc_get_tbfreq(void) >> >> ns++; >> >> - retval = atoi(ns); >> - return retval; >> + return atoi(ns); > > atoi() is lousy; it cannot properly detect user input errors. This > should probably be converted to use the appropriate qemu_strtol variant > instead.
But it's more or less okay here, it's parsing /proc/cpuinfo. Paolo
