On 28/09/2015 11:31, Markus Armbruster wrote: >> However, while changing the command to >> > >> > { 'command': 'netdev_add', 'data': 'Netdev', 'box': true, 'gen': false } >> > >> > for better introspection, you should keep 'gen':'false' and the manual >> > implementation based on qemu_opts_from_qdict, otherwise you break >> > backwards-compatibility. > Non sequitur :) > > We need to stay sufficiently backwards compatible somehow. 'gen' false > is one possible solution. Liberal use of alternate types could be > another. A special input visitor mode could be a third.
Agreed; my suggestion is the minimal change on top of this patch, actually undoing part of it. Any other approach should be done separately. Paolo > Since my review cursor is >30 patches behind this one, I don't have an > opinion, yet.