On 09/27/15 23:29, Gabriel L. Somlo wrote: > Signed-off-by: Gabriel Somlo <so...@cmu.edu> > --- > docs/specs/fw_cfg.txt | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/docs/specs/fw_cfg.txt b/docs/specs/fw_cfg.txt > index bc95404..4d85701 100644 > --- a/docs/specs/fw_cfg.txt > +++ b/docs/specs/fw_cfg.txt > @@ -77,6 +77,15 @@ increasing address order, similar to memcpy(). > Selector Register IOport: 0x510 > Data Register IOport: 0x511 > > +== ACPI Interface == > + > +The fw_cfg device is defined with ACPI ID "QEMU0002".
I'd have preferred spelling out "_HID" or "ACPI Hardware ID" here, but I agree that this wording matches that of "docs/specs/pvpanic.txt". > Since we expect > +ACPI tables to be passed into the guest through the fw_cfg device itself, > +the guest-side BIOS can not use ACPI to find fw_cfg. However, once the > +bios is finished setting up ACPI tables and hands control over to the Please replace both "BIOS" and "bios" with "firmware". > +guest kernel, the latter can use the fw_cfg ACPI node for a more accurate > +inventory of in-use IOport or MMIO regions. > + Looks good otherwise. For the next version: Reviewed-by: Laszlo Ersek <ler...@redhat.com> > == Firmware Configuration Items == > > === Signature (Key 0x0000, FW_CFG_SIGNATURE) === >
