Eric Blake <ebl...@redhat.com> writes: > On 10/01/2015 11:39 AM, Markus Armbruster wrote: > >>> I'm leaning towards A (calling self-inheritance a name collision is a >>> bit of a stretch in the first place; and leaving it untested until 16/46 >>> goes in doesn't hurt). >> >> Okay, A. it is. I pushed to branch qapi-next at >> http://repo.or.cz/qemu/armbru.git > > Branch looks good to go with one nit: 15/18 commit message (currently > e7462ff) has a typo in the text you massaged: > > The generated code has fewer blank line in qapi-event.c functions, > but has no semantic difference. > > s/line/lines/
Fixed and pushed. Thanks! > I'll rebase my remaining patches on top of your tip, and let you decide > how long to wait before sending the pull request. And with your rewrite > of 17/18, this part of the series no longer depends on the python 2.6 > configure patch. I'll wait a few days. We'll need the time to review the next batch of patches anyway.
