On 05/20/2010 07:49 AM, Gerd Hoffmann wrote:
Hi,
Well. You can't have both. We can have a efficiently packed format
(i.e.
two bitmaps). Or we can do it in a way which doesn't need parsing,
but that
wouldn't be the most compact format ...
You're right, so packing or introducing a small conversion function is
not critical. I'd still prefer a standard format if possible.
Personally, I'd rather see Gerd's original format but read from a file
instead of hard coded in a .c file. IOW, a
/usr/share/qemu/default-cursor.qpm that contained the appropriate
strings. A couple extra lines that made it an xpm I think would be worth
it too.
xpms are designed to be easily #include-able, and parsing them that
way is easier than loading them at runtime. At least without adding a
dependency to libXpm.
So how about the following incremental RfC patch? It adds the cursors
as separate files which are standard xpm format. Nevertheless they
are compiled in, i.e. they can't be changed at runtime.
That works for me. Nice job.
Regards,
Anthony Liguori
cheers,
Gerd
