On 07/10/2015 10:14, Pavel Dovgaluk wrote: > > It doesn't seem correct to call it for all checkpoints, but why > > is it right for timerlist_run_timers? > > Because replaying shouldn't proceed when machine is stopped.
Right, but VIRTUAL and VIRTUAL_RT do not proceed when the machine is stopped. For HOST it makes sense, but then the same should happen independent of the replay mode (using qemu_clock_enable). Otherwise, if a checkpoint for the wrong clock sneaks in at the wrong point while the VM is running, I wonder if replay could grind to a halt. Paolo > These checks could be also useful for creating snapshots in record mode, > but I don't remember exact reasons of adding them. I'll check your changes > for the current version.
