On 10/09/2015 09:56 AM, Thomas Huth wrote: > g_malloc0 already clears the memory, so no need for > the additional memset here. And while we're at it, > also convert the g_malloc0 to the preferred g_new0. > > Signed-off-by: Thomas Huth <th...@redhat.com> > --- > hw/dma/pxa2xx_dma.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Eric Blake <ebl...@redhat.com> > > diff --git a/hw/dma/pxa2xx_dma.c b/hw/dma/pxa2xx_dma.c > index d4501fb..54cdb25 100644 > --- a/hw/dma/pxa2xx_dma.c > +++ b/hw/dma/pxa2xx_dma.c > @@ -459,9 +459,8 @@ static int pxa2xx_dma_init(SysBusDevice *sbd) > return -1; > } > > - s->chan = g_malloc0(sizeof(PXA2xxDMAChannel) * s->channels); > + s->chan = g_new0(PXA2xxDMAChannel, s->channels); > > - memset(s->chan, 0, sizeof(PXA2xxDMAChannel) * s->channels); > for (i = 0; i < s->channels; i ++) > s->chan[i].state = DCSR_STOPINTR; > > -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
