On Tue, Oct 20, 2015 at 02:38:43PM +0200, Andreas Färber wrote: > Am 20.10.2015 um 14:15 schrieb Paolo Bonzini: > > On 20/10/2015 13:38, Pavel Fedin wrote: > >> Hello! Is there any progress on this? > >> 6/7 significantly improves startup performance, i'd like to have it > >> accepted. > > > > Me too. :) > > > > I am waiting for Andreas, since he's the maintainer for QOM. > > Pavel, adding a Tested-by does not automagically make the patch accepted. > > Two problems apart from time: 1) Discussions about iterator design, 2) > lack of test cases, and that applies to iterator-less v2, too. Circles > back to me (or someone) looking into qom-proplist test.
FYI in the v4 posting, I added to the check-qom-proplist.c test case to cover the new iterator APIs. I further added to it in the later patches to cover the iteration of properties against classes. The v4 also has the alternative iterator design that Markus / Paolo preferred, that avoids use of callback functions. I can further test cases to do more coverage of object proprty handling wrt to classes, if you want me to. Regards, Daniel -- |: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :| |: http://libvirt.org -o- http://virt-manager.org :| |: http://autobuild.org -o- http://search.cpan.org/~danberr/ :| |: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|