[Qemu-devel] Re: [PATCH 1/5] Exit if incoming migration fails

[Paolo Bonzini]

-void qemu_start_incoming_migration(const char *uri)
+int qemu_start_incoming_migration(const char *uri)
  {
      const char *p;
+    int ret = -1;

Maybe -ENOSYS or -EPROTONOSUPPORT, since the *_start_incoming_migration 
functions return a negative errno value?

      if (incoming) {
-        qemu_start_incoming_migration(incoming);
+        if (qemu_start_incoming_migration(incoming)<  0) {
+            fprintf(stderr, "unknown migration protocol: %s\n", incoming);
+            exit(1);
+        }

Dually, if you have a failure from *_start_incoming_migration, this 
fprintf is spurious.

Paolo