Hello! > Please don't do two things in one patch. (I actually read this patch > code-first and thought you'd accidentally inserted this change due > to a rebasing mishap...) It's particularly bad in patches which are > otherwise almost entirely moving code from one file to another, > because it's easy to overlook the substantive change in the resulting > large patch.
Ok, ok, sorry... I really wanted to push this in somehow, and i thought that maybe you'll like it as a little thing that completes the reusable API. Should i post v2 with this hunk removed? > > +typedef struct ARMCPUClass { > > + /*< private >*/ > > + CPUClass parent_class; > > + /*< public >*/ > > + > > + DeviceRealize parent_realize; > > + void (*parent_reset)(CPUState *cpu); > > +} ARMCPUClass; > > I'm slightly surprised we need to define the ARMCPUClass struct > here -- what needs the definition rather than just the typedef, > or is this just to follow other header files? Other header files, i believe, do it for a reason. To tell the truth i made the patch very quickly, and didn't have much time to dig in OBJECT_CLASS_CHECK() internals. Does it need a sizeof() maybe? And without it thing looked a bit ugly and incomplete. Class structure is pretty self-sufficient and straightforward, so i just moved it too. I'll reply to the rest of messages on monday, weekend is coming. :) Kind regards, Pavel Fedin Expert Engineer Samsung Electronics Research center Russia