> > I realise that. However I'd expect things to break if the guest OS > > devices to share an IRQ line between the HPET and some other device. > > The guest would share IRQ8, not the RTC output. So there would be no > difference to the current situation.
The difference is that you've removed the check that prevented overlap between the PIC and annother device. You should be using isa_reserve_irq/isa_init_irq before you use an ISA IRQ line. Any uses of isa_bus_irqs (including teh existing HPET code) are probably broken. Paul