On 10/30/2015 01:47 PM, Peter Maydell wrote: > On 30 October 2015 at 15:42, Markus Armbruster <arm...@redhat.com> wrote:
>> char: Convert to new qapi union layout > Hi; I'm afraid this doesn't build on w32: > > /home/petmay01/linaro/qemu-for-merges/qemu-char.c: In function > ‘qmp_chardev_open_file’: > /home/petmay01/linaro/qemu-for-merges/qemu-char.c:4051: error: > ‘ChardevBackend’ has no member named ‘file’ > /home/petmay01/linaro/qemu-for-merges/qemu-char.c: In function > ‘qmp_chardev_open_serial’: > /home/petmay01/linaro/qemu-for-merges/qemu-char.c:4073: error: > ‘ChardevBackend’ has no member named ‘serial’ I'm not set up for easily cross-compiling qemu to windows at the moment, which is why I missed it. But the fix is easy (sent separately). Hopefully that's the only #ifdef spot of code I missed, and we aren't going to play the "whack-a-mole" game of seeing what fails to compile on the next platform after my w32 fixup is squashed in. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature