On 05/25/2010 04:31 PM, Anthony Liguori wrote:
On 05/25/2010 08:19 AM, Avi Kivity wrote:
On 05/25/2010 04:03 PM, Anthony Liguori wrote:
I don't think that qdev device names and paths are something we
have to worry much about changing over time since they reflect
logical bus layout. They should remain static provided the
devices remain static.
Modulo mistakes. We already saw one (lack of pci domains). To
reduce the possibility of mistakes, we need reviewable documentation.
pci domains was only a mistake as a nice-to-have. We can add pci
domains in a backwards compatible way.
It adds a new level to the qdev tree.
The tree is not organized like that today. IOW, the PCI hierarchy is
not reflected in the qdev hierarchy. All PCI devices (regardless of
whether they're a function or a full slot) simply sit below the PCI bus.
That's a bug IMO, but regardless, s/qdev tree/pci device component of
the qdev path/.
--
error compiling committee.c: too many arguments to function
