On Mon 02 Nov 2015 06:29:14 PM CET, Eric Blake <ebl...@redhat.com> wrote: >>> @@ -103,7 +103,8 @@ function add_snapshot_image() >>> { 'options': >>> { 'driver': 'qcow2', 'node-name': 'snap_"${1}"', >>> "${extra_params}" >>> 'file': >>> - { 'driver': 'file', 'filename': '"${snapshot_file}"' } } } >>> }" >>> + { 'driver': 'file', 'filename': '"${snapshot_file}"', >>> + 'node-name': 'file_"${1}"' } } } }" >> >> Pre-existing, but do those "" actually do anything? >> > > Actually, the "" are wrong. Look at the full context: we have: > > cmd="..."${snapshot_file}"..." > > which means the expansion of $snapshot_file is _unquoted_.
Not really, it's quoted in all cases: 'node-name': 'snap_"${1}"' 'filename': '"${snapshot_file}"' 'node-name': 'file_"${1}"' But it's true that the double quotes don't do anything so I'll remove them. Berto