On 11/06/2015 08:54 AM, Stefan Hajnoczi wrote: > On Wed, Nov 04, 2015 at 08:19:31PM +0300, Denis V. Lunev wrote: >> with test >> while /bin/true ; do >> virsh snapshot-create rhel7 >> sleep 10 >> virsh snapshot-delete rhel7 --current >> done >> with enabled iothreads on a running VM leads to a lot of troubles: hangs, >> asserts, errors.
That is a case of using libvirt to trigger internal snapshots... > > The HMP monitor is legacy and also not used by modern libvirt. ...and libvirt is forced to use HMP for internal snapshots, since we _still_ haven't exposed internal snapshots as a QMP command. > I think the affected use cases are restricted to savevm+dataplane and > HMP+dataplane. The fact that the commit message calls out a libvirt method of triggering the bug does mean that it is user-visible, and so it would qualify as a bug fix even during hard freeze. But I also understand that taking a large complex series late in the game is not without risk; and it is not like this is a regression (rather, something that has never worked bulletproof), right? -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature