On 11/12/2015 03:22 AM, Prasanna Kumar Kalever wrote: > this patch is very much be meaningful after next patch which adds multiple > gluster servers support. After that, > > an example is, in 'servers' tuple values we use 'server' variable for key
Awkward line break mid-sentence. The commit message alone is not a reason to hold up this patch, so maybe the maintainer can adjust it. > 'host' in the code, it will be quite messy to have colliding names for > variables, so to maintain better readability and makes it consistent with > other > existing code as well as the input keys/options, this patch renames the > following variables I'd suggest replacing everything up to here with: A future patch will add support for multiple gluster servers. Our existing terminology is a bit unusual in relation to what names are used by other networked devices, and doesn't map very well to the terminology we expect to use for multiple servers. Therefore, rename the following options: > 'server' -> 'host' > 'image' -> 'path' > 'volname' -> 'volume' > > Signed-off-by: Prasanna Kumar Kalever <prasanna.kale...@redhat.com> > Reviewed-by: Eric Blake <ebl...@redhat.com> > --- > block/gluster.c | 54 +++++++++++++++++++++++++++--------------------------- > 1 file changed, 27 insertions(+), 27 deletions(-) R-b still stands on this one. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature