Markus Armbruster <arm...@redhat.com> writes: > Bandan Das <b...@redhat.com> writes: > >> There's no indication of any sort that i440fx doesn't support >> "iommu=on"" >> >> Signed-off-by: Bandan Das <b...@redhat.com> >> --- >> hw/pci-host/piix.c | 4 ++++ >> 1 file changed, 4 insertions(+) >> >> diff --git a/hw/pci-host/piix.c b/hw/pci-host/piix.c >> index 7b2fbf9..f12593a 100644 >> --- a/hw/pci-host/piix.c >> +++ b/hw/pci-host/piix.c >> @@ -301,6 +301,10 @@ static void i440fx_pcihost_realize(DeviceState *dev, >> Error **errp) >> static void i440fx_realize(PCIDevice *dev, Error **errp) >> { >> dev->config[I440FX_SMRAM] = 0x02; >> + >> + if (object_property_get_bool(qdev_get_machine(), "iommu", NULL)) { >> + fprintf(stderr, "i440fx doesn't support emulated iommu\n"); >> + } >> } >> >> PCIBus *i440fx_init(const char *host_type, const char *pci_type, > > error_report(), please. > > If this is just a warning, please prefix the message with "warning: ".
Sure will do. Yeah, it seems good enough just to print a message without exiting. > If it isn't, exit(1).