On Thu, 12 Nov 2015 19:00:54 +0100 Cornelia Huck <cornelia.h...@de.ibm.com> wrote: > On Mon, 09 Nov 2015 18:58:16 +0100 > Greg Kurz <gk...@linux.vnet.ibm.com> wrote: > > > If target is bi-endian (ppc64, arm), the virtio_legacy_is_cross_endian() > > indeed returns the runtime state of the virtio device. However, it returns > > false unconditionally in the general case. This sounds a bit strange > > given the name of the function. > > > > This helper is only useful for vhost actually, where indeed non bi-endian > > targets don't have to deal with cross-endian issues. > > > > This patch moves the helper to vhost.c and gives it a more appropriate name. > > > > Signed-off-by: Greg Kurz <gk...@linux.vnet.ibm.com> > > --- > > hw/virtio/vhost.c | 17 +++++++++++++++-- > > include/hw/virtio/virtio-access.h | 13 ------------- > > 2 files changed, 15 insertions(+), 15 deletions(-) > > That's on top of your vnet header cleanup, right? With that in mind: >
Yes. > Reviewed-by: Cornelia Huck <cornelia.h...@de.ibm.com> Thanks for your time ! -- Greg
