On Fri, 2015-11-13 at 13:46 +0000, Stefano Stabellini wrote: > On Fri, 13 Nov 2015, Roger Pau Monne wrote: > > Due to the addition of HVMlite and the requirement to always provide a > > valid > > xc_domain_configuration_t, xc_domain_create now always takes an arch > > domain > > config, which can be NULL in order to mimic previous behaviour. > > > > Add a small stub called xen_domain_create that encapsulates the correct > > call > > to xc_domain_create depending on the libxc version detected. > > > > Signed-off-by: Roger Pau Monné <roger....@citrix.com> > > FYI this is going to conflict with Ian's series: > > 1447070487-31229-1-git-send-email-ian.campb...@citrix.com
The bit being patched here is disabled by "xen: make it possible to build without the Xen PV domain builder" in that series. In any case I think Roger's stuff would be better off going in first and I can easily rebase over it. > In addition, the patch causes a build failure against most Xen versions: > > In file included from > /local/scratch/sstabellini/qemu/include/hw/xen/xen_backend.h:4:0, > from hw/block/xen_disk.c:38: > /local/scratch/sstabellini/qemu/include/hw/xen/xen_common.h:445:37: > error: unknown type name ‘xc_domain_configuration_t’ > CC hw/bt/hci-csr.o > make: *** [hw/block/xen_disk.o] Error 1 Given the only caller today passes NULL I'd suggest moving the NULL down into the wrapper, i.e. dropping the argument from xen_domain_create. If someone wants to resurrect the domain build in QEMU _and_ teach it to do pvh, then they will surely be able to refactor this to suit their needs. Ian.
