On 15 November 2015 at 20:30, Sergey Fedorov <serge.f...@gmail.com> wrote: > On 14.11.2015 22:45, Peter Maydell wrote: >> On 13 November 2015 at 21:13, Sergey Fedorov <serge.f...@gmail.com> wrote: >>> Thank you a lot for your explanation! It was really helpful for >>> understanding the code :) One thing I wasn't sure of was whether this >>> "dc->condjmp = 0" means that "condition failed" codepath below will also >>> generate an exception whereas it shouldn't? >> You want a singlestep exception for both conditional-insn >> failed and conditional-insn passed (either way we've executed >> the instruction and should return control to the debugger). > > To be clear, I mean SWI/HVC/SMC exceptions could be generated when > singlestepping through a conditional-insn failed codepath.
When I read through the code earlier I thought that wasn't possible, but rereading it I see what you mean. I wonder if we introduced that accidentally adding some of the extra features along the way or if it's always been wrong like that... thanks -- PMM
