On 11/18/2015 11:25 AM, Markus Armbruster wrote: > Eric Blake <ebl...@redhat.com> writes: > >> The name QType is more in line with our conventions for qapi >> types, and matches the fact that each enum member has a prefix >> of QTYPE_. >> >> Signed-off-by: Eric Blake <ebl...@redhat.com> > > At this point, the connection to QAPI is unobvious. > > You can either point to CODING_STYLE, which ask for type names in > CamelCase, or to the next patch.
How about: The name QType matches our CODING_STYLE conventions for type names in CamelCase. It also matches the fact that we are already naming all the enum members with a prefix of QTYPE, not QTYPE_CODE. And doing the rename will also make it easier for the next patch to use QAPI for the enum, which also wants CamelCase type names. Feel free to touch up the commit message as you see fit. -- Eric Blake eblake redhat com +1-919-301-3266 Libvirt virtualization library http://libvirt.org
signature.asc
Description: OpenPGP digital signature
