From: "Dr. David Alan Gilbert" <[email protected]> The check is unneccesary, we read the value at the start of the thread, use it, and never change it. The value is checked to be non-NULL before thread creation.
Spotted by coverity, CID 1339211 Signed-off-by: Dr. David Alan Gilbert <[email protected]> Signed-off-by: Juan Quintela <[email protected]> --- migration/migration.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/migration.c b/migration/migration.c index 265d13a..1a42aee 100644 --- a/migration/migration.c +++ b/migration/migration.c @@ -1345,7 +1345,7 @@ static void *source_return_path_thread(void *opaque) break; } } - if (rp && qemu_file_get_error(rp)) { + if (qemu_file_get_error(rp)) { trace_source_return_path_thread_bad_end(); mark_source_rp_bad(ms); } -- 2.5.0
