On 19/11/2015 13:17, Pavel Fedin wrote: > Ok, good. So, this has already been tested. Ok, i think i can further extend > this patch by: > 1. Add a flag to disable memory_region_dispatch_write_ioeventfds(), to be set > by KVM code for example. So that with KVM we have even > smaller performance degradation. > 2. Issue a one-shot warning, like in my current patch, so that the user knows > that his/her kernel prevents from getting the best > performance. > Will it be OK then?
Yes! However QEMU pretty much always tries to use ioeventfd for virtio. I'm not sure you want to warn outside the special cases of vhost or dataplane... So perhaps it's better to warn in the vhost and dataplane case specifically, rather than always. Paolo
