Quoting Eric Blake (2015-11-25 10:02:55) > On 11/25/2015 05:59 AM, marcandre.lur...@redhat.com wrote: > > From: Marc-André Lureau <marcandre.lur...@redhat.com> > > > > This test exhibits a POSIX behaviour regarding switching between write > > and read. It's undefined result if the application doesn't ensure a > > flush between the two operations (with glibc, the flush can be implicit > > when the buffer size is relatively small). The previous commit fixes > > this test. > > > > Related to: > > https://bugzilla.redhat.com/show_bug.cgi?id=1210246 > > > > Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com> > > --- > > tests/test-qga.c | 95 > > ++++++++++++++++++++++++++++++++++++++++++++++++++++++-- > > 1 file changed, 93 insertions(+), 2 deletions(-) > > Reviewed-by: Eric Blake <ebl...@redhat.com> > > > + /* seek to 0 */ > > + cmd = g_strdup_printf("{'execute': 'guest-file-seek'," > > + " 'arguments': { 'handle': %" PRId64 ", " > > + " 'offset': %d, 'whence': %d } }", > > + id, 0, SEEK_SET); > > We still have a conflict between this series and my proposal to codify 0 > rather than relying on platform-specific SEEK_SET; Markus had the > suggestion of using QGA_SET (or QGA_SEEK_SET). Are we trying to get > both your series and my v2 patch into 2.5? Knowing that will help me > decide whether my v2 should be rebased on top of your patches.
I was planning on pulling in your patch on top of this for the next 2.5 pull, so rebasing on top of this series is probably best. > > -- > Eric Blake eblake redhat com +1-919-301-3266 > Libvirt virtualization library http://libvirt.org >