On 27/11/2015 08:03, Peter Xu wrote:
> > > +{ 'struct': 'DumpStatus',
> > > + 'data': { 'status': 'str', 'percentage': 'str' } }
> >
> > I suggest using enum for "status" and int for "percentage" (or two ints for
> > "total" and "current").
>
> Yes, I picked string just for flexibility. Regarding to this
> interface issue, I'd like to wait for others' comments too before
> modification.
I like Fam's idea of using an enum and two ints.
Also, the command should be named query-dump and the corresponding HMP
command should be "info dump" (by defining "dump" in hmp-commands-info.h".
Paolo
