Markus Armbruster wrote: > Luiz Capitulino <lcapitul...@redhat.com> writes: > >> On Sun, 23 May 2010 12:59:26 +0200 >> Jan Kiszka <jan.kis...@web.de> wrote: >> >>> From: Jan Kiszka <jan.kis...@siemens.com> >>> >>> Ported commands that are marked 'user_only' will not be considered for >>> QMP monitor sessions. This allows to implement new commands that do not >>> (yet) provide a sufficiently stable interface for QMP use (e.g. >>> device_show). >> This is fine for me, but two things I've been wondering: >> >> 1. Isn't a 'flags' struct member better? So that we can do (in the >> qemu-monitor.hx entry): >> >> .flags = MONITOR_USER_ONLY | MONITOR_HANDLER_ASYNC, >> >> I'm not suggesting this is an async handler, just exemplifying multiple >> flags. > > We also have at least one command that makes only sense in QMP: > qmp_capabilities. Maybe we could use separate flags controlling command > availability in human monitor and QMP.
Sounds reasonable. Then I think I will lay the ground for this by introducing flags already in this patch. A v4 run is required anyway. Jan
signature.asc
Description: OpenPGP digital signature
