On Mon, Nov 30, 2015 at 12:21:23PM +0100, Paolo Bonzini wrote: > > > On 28/11/2015 20:56, Eduardo Habkost wrote: > > I still need to figure out a way to write unit tests for the new > > code. Maybe I will just copy and paste the new and old functions, > > and test them locally (checking if they give the same results > > when translating blobs of random bytes). > > Aren't the QEMU_BUILD_BUG_ON enough? No need to delete them in patch 3, > though perhaps you can remove the #defines.
Just wanted to be 100% sure. Even if the offets are all correct, I might have made other mistakes when translating the get/save code. About the QEMU_BUILD_BUG_ON lines, we can keep them if you like. We could translate the uint32_t offsets to byte offsets after ptach 3/3, to make them easier to compare to the Intel docs. -- Eduardo
